Subin min #6
Open
Subin min #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello-Worldismine
commented
Jul 30, 2025
Hello-Worldismine
commented
- useWindowSize 구현
- useCountdown 구현
- useTextColor 구현
There was a problem hiding this comment.
간단하지만 아이디어가 좋은 것 같아요
필요 없는 주석은 삭제해도 좋을 것 같아요
jyeon03
reviewed
Aug 4, 2025
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; | ||
| const nextColor = colors[Math.floor(Math.random() * colors.length)]; | ||
| setColor(nextColor); | ||
| }; |
Member
There was a problem hiding this comment.
정해진 목록뿐만이 아니라 랜덤으로 색상 변경하는 것까지 구현하셨네요!
krlyeon
approved these changes
Aug 5, 2025
Comment on lines
+10
to
+14
| // 예시로 색상을 랜덤하게 바꾸거나, 정해진 목록에서 바꿀 수 있음 | ||
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; | ||
| const nextColor = colors[Math.floor(Math.random() * colors.length)]; | ||
| setColor(nextColor); | ||
| }; |
wonpark1
reviewed
Aug 5, 2025
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; | ||
| const nextColor = colors[Math.floor(Math.random() * colors.length)]; | ||
| setColor(nextColor); | ||
| }; |
thisminji
reviewed
Aug 7, 2025
| import { useState } from 'react'; | ||
|
|
||
| export const useTextColor = () => { | ||
| // 여러분의 use{Something}을 만들어주세요! |
There was a problem hiding this comment.
커스텀 훅의 목적이 분명해서 보기 좋아요!
글자 색상을 바꾸는 로직이라는 게 useTextColor라는 이름만 봐도 바로 느껴져서, 함수명을 직관적으로 잘 지으신 것 같아용
Soi-coding
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
색상 배열의 개수에 맞게 Math.floor(Math.random() * colors.length) 라고 코드 잘 작성해주신 것 같아요!
leeboyeon17
reviewed
Aug 28, 2025
| const changeColor = () => { | ||
| // 예시로 색상을 랜덤하게 바꾸거나, 정해진 목록에서 바꿀 수 있음 | ||
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; | ||
| const nextColor = colors[Math.floor(Math.random() * colors.length)]; |
There was a problem hiding this comment.
목록에서의 선택과 랜덤 변경을 모두 가능하게 해 둔 점이 인상 깊어요! UI에서 랜덤 선택 버튼을 따로 만들어봐도 재밌을 것 같습니다
seoyeon435
reviewed
Aug 28, 2025
| const changeColor = () => { | ||
| // 예시로 색상을 랜덤하게 바꾸거나, 정해진 목록에서 바꿀 수 있음 | ||
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; | ||
| const nextColor = colors[Math.floor(Math.random() * colors.length)]; |
There was a problem hiding this comment.
버튼 클릭할 때마다 텍스트 색이 달라지는 경험이 직관적이면서도 재밌는 것 같습니다!
Hyunuk-Lee
reviewed
Aug 28, 2025
Comment on lines
+7
to
+12
| const [color, setColor] = useState('black'); | ||
|
|
||
| const changeColor = () => { | ||
| // 예시로 색상을 랜덤하게 바꾸거나, 정해진 목록에서 바꿀 수 있음 | ||
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; | ||
| const nextColor = colors[Math.floor(Math.random() * colors.length)]; |
There was a problem hiding this comment.
changeColor 시 기존 색상과 같은 값이 다시 나올 수 있는데 while 루프나 필터링으로 개선 가능할 것 같습니다
HongYounKim
reviewed
Aug 28, 2025
|
|
||
| const changeColor = () => { | ||
| // 예시로 색상을 랜덤하게 바꾸거나, 정해진 목록에서 바꿀 수 있음 | ||
| const colors = ['red', 'blue', 'green', 'orange', 'purple']; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.