Revert BC breaking changes for PHP 5.5+ in ReactRenderer v4 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nacmartin and the team at Limenius,
Thanks for setting all up. Much appreciated.
As outlined in #39 There are some breaking BC changes with php v5 in V4+ of the app. This PR aims to add that compatibility back into the mainline for the v4 of this package.
Note that this needs merging into a new branch split for v4 dev from 83383e0 and not master. Would be happy to rebase if you create the new branch is open on the main repo. (Not v5 due to issues outlined in #40 which I am not sure there is much we can do about)
Thanks!