Remove set_stack_pointer.o references from app compile scripts#215
Merged
qianxichen233 merged 1 commit intomainfrom Apr 29, 2026
Merged
Remove set_stack_pointer.o references from app compile scripts#215qianxichen233 merged 1 commit intomainfrom
qianxichen233 merged 1 commit intomainfrom
Conversation
Contributor
|
looks good to me, if someone more familiar with the app repo can make sure this covers all the app we have right now, that'd be great |
Contributor
yeah this needs to cover more of the apps i believe Its outdated |
rennergade
approved these changes
Apr 27, 2026
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
I think this wasnt added to the other apps so it seems fine.
qianxichen233
approved these changes
Apr 27, 2026
Yaxuan-w
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes remaining references to
set_stack_pointer.ofrom application compile scripts inlind-wasm-apps.This is a companion PR to the
lind-wasmchange for deprecatingset_stack_pointer.o: Lind-Project/lind-wasm#1120. Afterset_stack_pointer.ois removed from the sysroot/build outputs, app-side dynamic linking scripts should no longer require or link this object.Both PR should be merged together to make sure nothing is breaking
Changes
set_stack_pointer.ofrom dynamic linking CRT object lists in app compile scripts.set_stack_pointer.o.Related Issue / PR
Related to Lind-Project/lind-wasm issue:
glibc: depreciate set_stack_pointer.o #978Companion PR for the corresponding
lind-wasmchange.Validation
set_stack_pointer.oreferences in app compile scripts.set_stack_pointer.o.