copy_handler_table_to_cage: 1. Fix incorrect argument usage 2. Overwrite target cage table.#1113
Open
stupendoussuperpowers wants to merge 3 commits intomainfrom
Open
copy_handler_table_to_cage: 1. Fix incorrect argument usage 2. Overwrite target cage table.#1113stupendoussuperpowers wants to merge 3 commits intomainfrom
copy_handler_table_to_cage: 1. Fix incorrect argument usage 2. Overwrite target cage table.#1113stupendoussuperpowers wants to merge 3 commits intomainfrom
Conversation
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
CI tests pass on this so not a breaking change, we should discuss whether this change is acceptable since the fs-tee-grate relies on this. |
Yaxuan-w
reviewed
Apr 25, 2026
Member
Yaxuan-w
left a comment
Yaxuan-w
left a comment
There was a problem hiding this comment.
The change looks good to me. Can you also put a unit test for this?
Contributor
Author
What kind of test should I add? A grate test? |
Member
Yes. |
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
Added the test, re-requesting review. |
Yaxuan-w
approved these changes
Apr 26, 2026
rennergade
approved these changes
Apr 26, 2026
Contributor
rennergade
left a comment
rennergade
left a comment
There was a problem hiding this comment.
I think this works. Want to get @JustinCappos approval on this before merge.
Member
The functionality of copying a handler table wasn't well thought out. I was thinking mostly of needing to support fork and perhaps some filter grates. I wanted to make something simple and hard to mess up. Perhaps something which takes a starting call number and ending call number to map makes sense? Maybe this also needs to apply a change so that all system call number offsets start at their location - the starting call number + some provided argument. (Obviously integer over/underflows need to be carefully checked here.) As for deleting or merging into the existing table, this also could be an option. This all is starting to seem a bit more complex. So we need really clear testing if we go this route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 1 fix and 1 change:
Fix:
copy_handler_table_to_cagein 3i mismatched the argument orders in glibc, fixed that, and updated the usage in fork_syscall to match this.Change (needs discussion if this passes CI):
Right now copy handler table to cage merges source into target cage's handler table, for the fs-tee-grate, it's useful to have a functionality where we completely overwrite the target handler table with that of source's. This essentially let's us rewrite a cage's parent cage as far as the inheritance of handler tables is concerned.
As as example -
If these are run linearly, 3 inherits all handlers on 2, if we have the ability to overrwrite handler tables, we can copy 1 into 3 and 3 now for all routing purposes behaves as if it's a direct child of 1.
My questions are:
Was the decision to merge these two tables deliberate, and if so, for which use case?
Does this change break any key assumptions we have about this function?