Fix debug build#1119
Open
rennergade wants to merge 1 commit intomainfrom
Open
Conversation
rennergade
force-pushed
the
fix-debug-build
branch
2 times, most recently
from
301b3ee to
58ac112
Compare
In the dynamic build, crt1_shared.o calls lind_debug_printf (when compiled with LIND_DEBUG), but the shared libc didn't export it. wasm-ld with --allow-undefined turned it into an unresolved import, causing "unknown import: env::lind_debug_printf" at runtime. Add --export-if-defined=lind_debug_printf to the shared libc link.
rennergade
force-pushed
the
fix-debug-build
branch
from
58ac112 to
20732d3
Compare
Contributor
End-to-End Test ReportTest PreviewUnified Test Report grate harness
Cases
static harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
wasm harnessTest ReportDeterministic TestsSummary
Test Results by Category
Fail TestsSummary
Test Results by Category
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
drapl0n
approved these changes
Apr 26, 2026
Yaxuan-w
approved these changes
Apr 26, 2026
qianxichen233
requested changes
Apr 27, 2026
Contributor
qianxichen233
left a comment
qianxichen233
left a comment
There was a problem hiding this comment.
previously a commit accidentally deleted all the debug related functions in lind_debug.c: 0f386b3, specifically, lind_debug_num and lind_debug_import are all gone
Later for some reason, lind_debug_import in crt1 is replaced into lind_debug_printf, which is also not an expected change: 4265012
All of these changes need to revert back and this will naturally fix the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1118
Needed to add lind_debug_printf to shared script.