v1.6.0 Host Inferface #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Require PACKED to be defined at project level
still have issue with communication after info scan
Seperate wake up bytes from header
dont use repeater. Reuse memory for gateway list in symphony.
tsteinholz
commented
Oct 25, 2019
Comment on lines
-82
to
+96
| return ret; | ||
| return LL_IFC_ACK; |
There was a problem hiding this comment.
Should this return the ret, not always true?
swohlerLL
approved these changes
Oct 25, 2019
There are some Rx errors, trying different things to fix. Also adding xmodem functions to program the symphony module on the AP
|
@JBB677 does this PR cover all the latest code? or is there any unreleased? |
|
Some unreleased. Im testing now.
…On Thu, Jan 2, 2020 at 10:15 AM тнσмαѕ ѕтєιинσℓz ***@***.***> wrote:
@JBB677 <https://github.com/JBB677> does this PR cover all the latest
code? or is there any unreleased?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AM5NWIKFQBRH5FGBZ3AFM63Q3YAH3A5CNFSM4JFD4OVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH6SBTQ#issuecomment-570237134>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM5NWINXGW7VUHWVOLRWA5DQ3YAH3ANCNFSM4JFD4OVA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to updated the IFC for the 1.6.0 release of the module.