Skip to content

WIP: Fix panic due to the package is missing #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Fix panic due to the package is missing #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 25 additions & 19 deletions cmd/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,25 +125,31 @@ func (o *installOption) runE(cmd *cobra.Command, args []string) (err error) {
}

process := &installer.Installer{
Source: o.downloadOption.Output,
Name: o.name,
Package: o.Package,
Tar: o.Tar,
Output: o.Output,
CleanPackage: o.CleanPackage,
AdditionBinaries: o.Package.AdditionBinaries,
}
// install requirements tools in the post phase
if len(o.Package.Requirements) > 0 {
if len(o.Package.PostInstalls) == 0 {
o.Package.PostInstalls = make([]installer.CmdWithArgs, 0)
}
for i := range o.Package.Requirements {
tool := o.Package.Requirements[i]
o.Package.PostInstalls = append(o.Package.PostInstalls, installer.CmdWithArgs{
Cmd: "hd",
Args: []string{"install", tool},
})
Source: o.downloadOption.Output,
Name: o.name,
Package: o.Package,
Tar: o.Tar,
Output: o.Output,
CleanPackage: o.CleanPackage,
}

// TODO consider how to handle if the package is missing
// maybe it's possible to provide a default strategy for it.
if o.Package != nil {
process.AdditionBinaries = o.Package.AdditionBinaries

// install requirements tools in the post phase
if len(o.Package.Requirements) > 0 {
if len(o.Package.PostInstalls) == 0 {
o.Package.PostInstalls = make([]installer.CmdWithArgs, 0)
}
for i := range o.Package.Requirements {
tool := o.Package.Requirements[i]
o.Package.PostInstalls = append(o.Package.PostInstalls, installer.CmdWithArgs{
Cmd: "hd",
Args: []string{"install", tool},
})
}
}
}
err = process.Install()
Expand Down