Add option to leave files where they are while importing library#503
Open
T4g1 wants to merge 5 commits intoListenarrs:canaryfrom
Open
Add option to leave files where they are while importing library#503T4g1 wants to merge 5 commits intoListenarrs:canaryfrom
T4g1 wants to merge 5 commits intoListenarrs:canaryfrom
Conversation
T4g1
force-pushed
the
fix/494-library-safe-imports
branch
from
df07abd to
19eed3f
Compare
… on files and set monitoring
T4g1
force-pushed
the
fix/494-library-safe-imports
branch
from
2024229 to
b5cf323
Compare
therobbiedavis
requested changes
Apr 14, 2026
Collaborator
therobbiedavis
left a comment
therobbiedavis
left a comment
There was a problem hiding this comment.
Solid job! Thank you! Just a few changes and a request to please update the changelog!
Contributor
Author
|
@therobbiedavis Thanks! I did a pass on your reviews, can you check again to see if we are aligned ? |
therobbiedavis
requested changes
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
@T4g1 Added a couple comments on the existing issues, outside of these it lgtm!
T4g1
force-pushed
the
fix/494-library-safe-imports
branch
from
cf941b4 to
b6d2cce
Compare
Contributor
Author
|
Ready for re-review i believe |
therobbiedavis
requested changes
Apr 16, 2026
T4g1
force-pushed
the
fix/494-library-safe-imports
branch
from
923b9e3 to
0ca7bb4
Compare
Contributor
Author
|
Should be good, let me know if you see other things to change |
therobbiedavis
requested changes
Apr 16, 2026
T4g1
force-pushed
the
fix/494-library-safe-imports
branch
from
0ca7bb4 to
a8c911a
Compare
Contributor
Author
|
Done :D |
therobbiedavis
approved these changes
Apr 16, 2026
Collaborator
therobbiedavis
left a comment
therobbiedavis
left a comment
There was a problem hiding this comment.
lgtm! Just update the changelog from unreleased to 0.2.71 with today's date and we can merge it in (barring any codeql issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added
Testing
Notes
Next steps