LF-4618 Fix remove error entry when click X on number input

[Tbrid]

Description

Bug: error value in animals count input not restored to default value when clicking "X".
Cause: default value not being used and logic of restoring default is wrong.
Fix: Change default value logic to be using prop default value instead of current value in the field and add default value prop to field input

Jira link: https://lite-farm.atlassian.net/browse/LF-4618

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Passes test case
• UI components visually reviewed on desktop view
• UI components visually reviewed on mobile view
• Other (please explain)

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• The precommit and linting ran successfully
• I have added or updated language tags for text that's part of the UI
• I have added "MISSING" for all new language tags to languages I don't speak
• I have added the GNU General Public License to all new files

[Duncan-Brain]

Hi @Tbrid I think the defaultValue was placed as the last option was for the case where one arrives at the form with pre-filled values.

So one example is when you navigate to the next page of the form and then you go back in the form flow:

Screen.Recording.2025-01-16.at.7.19.10.PM.mov

One other thing about this field surprises me: it does not validate when blurred. It validates when another field is validated which makes sense. But it seems like it should also be validating on blur.

[Duncan-Brain]

Thanks looking good to me !

[SayakaOno]

initialValue is field.value || get(formState.defaultValues, name) || defaultValue, so I don't think this would work unless defaultValue is passed to this component.
Can we think of a way to use the correct initialValue instead?

[Tbrid]

I am not sure what you mean? The defaultValue is being passed as a prop.

[SayakaOno]

Sorry, the issue is that initialValue is set as field.value || get(formState.defaultValues, name) || defaultValue (line 64), but reset() sets the value to defaultValue.

LiteFarm/packages/webapp/src/components/Form/NumberInput/index.tsx

Lines 63 to 65 in 0f8a278

	const { inputProps, reset, numericValue, increment, decrement } = useNumberInput({
	initialValue: field.value || get(formState.defaultValues, name) || defaultValue,
	allowDecimal,

When resetting, we expect the input to display initialValue, but if field.value or get(formState.defaultValues, name) is used, reset() won’t work as expected.

reset: () => update(initialValue ?? NaN) in useNumberInput seems correct, but the problem is that initialValue changes. Can you think of a way to ensure reset() always works when field.value or get(formState.defaultValues, name) is used as initialValue?