Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] LF-4691: UI to connect to ensemble #3675

Draft
wants to merge 28 commits into
base: integration
Choose a base branch
from

Conversation

SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Jan 31, 2025

TODO: Delete unused files and code

Description

  • Add Partners component (to be renamed to Addons or something similar later)
    • The position of the cross icon for clearing error is off - this will be fixed in another ticket
  • Update PostSensor container
    • API integration (POST farmAddon, GET sensors)
    • Remove white background colour from the form (Loïc confirmed!)
  • Add translations and colours (Includes translations and colours for LF-4693 and 4696 🙏)
  • Make Loading component fixed relative to viewport (The file is currently nested within ContextForm, but I plan to extract it in a future PR. Keeping it for now to avoid a bigger diff)
  • Implement ability to hide Previous button in WithStepperProgressBar
  • Add isCompactSideMenu prop to POST_SENSOR_URL route
  • Update Map component
    • Navigate to the Add sensors form when "Sensor" is selected
    • Remove sensor upload related code
  • Update ContextForm to accept formMode prop ("onBlur", "onChange" etc.)

Jira link: https://lite-farm.atlassian.net/browse/LF-4691

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno added enhancement New feature or request new translations New translations to be sent to CrowdIn are present labels Jan 31, 2025
@SayakaOno SayakaOno self-assigned this Jan 31, 2025
* send showPreviousButton prop to ContextForm
@SayakaOno SayakaOno force-pushed the LF-4691/UI_to_connect_to_Ensemble branch from 19482a5 to 33aa699 Compare February 1, 2025 00:39
@SayakaOno SayakaOno changed the title LF-4691: UI to connect to ensemble [WIP] LF-4691: UI to connect to ensemble Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new translations New translations to be sent to CrowdIn are present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant