Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4699(1): Display sensor readings on the UI #3714

Merged
merged 39 commits into from
Mar 26, 2025
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d26723c
LF-4699 Fix getSensorReadings API response type in apiSlice
SayakaOno Mar 4, 2025
1e191d0
LF-4699 Update esid type in SensorDatapoint to allow missing keys
SayakaOno Mar 4, 2025
23d18f3
LF-4699 Add colors to theme colors
SayakaOno Mar 5, 2025
4e043be
LF-4699 Add LineChart component
SayakaOno Mar 5, 2025
1b7c052
LF-4699 Add chart util functions
SayakaOno Mar 5, 2025
5a7246b
LF-4699 Add tests for chart util functions
SayakaOno Mar 5, 2025
7550c60
LF-4699 Add LineChart stories
SayakaOno Mar 5, 2025
daff1c6
LF-4699 Fix chart red line colour
SayakaOno Mar 5, 2025
121222a
LF-4699 Fix date range
SayakaOno Mar 6, 2025
187fd0f
LF-4699 Hide line dots
SayakaOno Mar 6, 2025
c97fa9f
LF-4699 Rename sensor chart util test file, fix import
SayakaOno Mar 6, 2025
b6998c5
LF-4699 Export getNextDateTime function
SayakaOno Mar 6, 2025
2989d33
LF-4699 Extract getTicks function
SayakaOno Mar 6, 2025
f8c2a18
LF-4699 Fix getTicks bugs
SayakaOno Mar 7, 2025
6275691
LF-4699 Optimize sensor data formatting
SayakaOno Mar 11, 2025
78e5a8d
LF-4699 Limit the number of daily ticks to a maximum of 7
SayakaOno Mar 11, 2025
2b07416
LF-4699 Make getTicks functions more flexible
SayakaOno Mar 12, 2025
b986260
LF-4699 Limit the number of ticks to 7
SayakaOno Mar 12, 2025
d16cb25
LF-4699 Make getDailyTicks function timezone agnostic
SayakaOno Mar 13, 2025
46d60d4
LF-4699 Add tests for getTicks function
SayakaOno Mar 13, 2025
1da62b9
LF-4699 Simplify getTicks function, add JSDoc, adjust story
SayakaOno Mar 13, 2025
34c7125
LF-4699 Make stories timezone agnostic
SayakaOno Mar 14, 2025
4878df6
LF-4699 Remove colors definition from LineChart, tweaks
SayakaOno Mar 14, 2025
a1e41f5
LF-4699 Improve LineChart
SayakaOno Mar 14, 2025
afaea93
LF-4699 Show dots when there are 12 or fewer data points
SayakaOno Mar 14, 2025
f920ecb
LF-4699 Add and improve stories
SayakaOno Mar 14, 2025
fa45f0a
LF-4699 Add comment for LineChart
SayakaOno Mar 14, 2025
6081929
LF-4699 Simplify JSDoc for getTicks
SayakaOno Mar 14, 2025
0a4365f
Revert "LF-4699 Update esid type in SensorDatapoint to allow missing …
SayakaOno Mar 14, 2025
956d567
Revert "LF-4699 Fix getSensorReadings API response type in apiSlice"
SayakaOno Mar 14, 2025
2614fbf
LF-4699 Remove utils for container and associated tests (to be re-add…
SayakaOno Mar 14, 2025
10cf9e5
LF-4699 Correct mistakes in comments
SayakaOno Mar 14, 2025
7c8781a
LF-4699 Update CSS variable name lineColor to tooltipColor
SayakaOno Mar 14, 2025
45613cf
LF-4699 Tweaks
SayakaOno Mar 14, 2025
bac7752
LF-4699 Corrections and tweaks
SayakaOno Mar 17, 2025
3eaba57
LF-4699 Add story for monthly ticks
SayakaOno Mar 17, 2025
6ffb57a
Merge branch 'integration' into LF-4699/Display_sensor_readings_on_th…
SayakaOno Mar 18, 2025
2616e08
Extract CustomTooltip
SayakaOno Mar 25, 2025
a1699ae
LF-4699 Update chart colour keys
SayakaOno Mar 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
LF-4699 Show dots when there are 12 or fewer data points
  • Loading branch information
SayakaOno committed Mar 14, 2025
commit afaea93210312dee6d1502a9f315633b21cb01ce
2 changes: 1 addition & 1 deletion packages/webapp/src/components/Charts/LineChart.tsx
Original file line number Diff line number Diff line change
@@ -196,7 +196,7 @@ function LineChart(props: LineChartProps) {
stroke={color}
strokeWidth={3}
hide={hiddenLines.includes(id)}
dot={false}
dot={data.length > 12 ? false : { r: 4 }}
activeDot={{
r: 6,
fill: activeLine === id ? color : 'transparent',