-
Notifications
You must be signed in to change notification settings - Fork 86
LF-4627 [Nice to have] Implement Add to Map redesign #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antsgar
merged 20 commits into
integration
from
LF-4627-nice-to-have-implement-add-to-map-redesign
Mar 28, 2025
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b95ff09
LF-4627 Render closed drawer inert (cannot be tabbed to)
kathyavini dad66be
Add left direction option to SIDE_DRAWER variant
kathyavini 05a04f2
Update Stories. Also add story for addBackdrop: false
kathyavini cab9ede
Remove unnecessary prop (DesktopDrawerVariant has no relevance in mob…
kathyavini 438e513
Make MapDrawer into a left-opening SIDE_DRAWER
kathyavini 431258e
Create and use new styling class to pass to sideDrawer without impact…
kathyavini 33f48be
Update 'add' icon and text
kathyavini 698b9ed
Add a hover state to the map menu items
kathyavini f653e66
Update the section (area, lines, points) headers
kathyavini 49f7f66
Merge branch 'integration' into LF-4627-nice-to-have-implement-add-to…
kathyavini bb1593d
LF-4627 Close Add to Map drawer when unmounting the Map component
kathyavini 5558b0b
LF-4627 Fix console error from incorrect capitalization on propTypes
kathyavini 6d1166a
LF-4627 Small adjusts -- comments
kathyavini ba2de86
LF-4627 Adjust Drawer CSS classes to allow for visual properties to b…
kathyavini da2ac46
LF-4627 Create option for a drawer with shadow visible on scroll; app…
kathyavini 9d8c503
Revert "LF-4627 Create option for a drawer with shadow visible on scr…
kathyavini 9475217
LF-4627 Give all drawers a border radius of 4px
kathyavini f59ab3b
LF-4627 Add 'desktop' to sideDrawer classes and props
kathyavini 863e453
Merge branch 'integration' into LF-4627-nice-to-have-implement-add-to…
kathyavini 96017ce
LF-4627 Create union type
kathyavini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely unrelated but this was my typo from #3710 in two files that was causing a console warning: