-
Notifications
You must be signed in to change notification settings - Fork 93
Lf 4948 snackbar should be full width and centered on mobile #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lf 4948 snackbar should be full width and centered on mobile #3897
Conversation
…dia query into main class
…ws swapping language to not disrupt snackbar position
kathyavini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for mobile looks good and the re-org of selectors makes sense to me!
There are just two small introduced bugs that are detailed in-line below. One is the Malayalam width override has been lost, and the other is that snackbar width is no longer responsive to the compact side menu state
Just a few selector issues contributing to that, mentioned below. Rest LGTM!
|
Thanks @kathyavini ! I swear I triple checked these cases haha but thanks for finding those bugs! |
Description
This fixes the main centering and incorrect width issues with the snackbar.
Notes:
Scrollbar:

Pre-existing but the scrollbar creates a noticeable difference in centering in some screen sizes. For top level centering like tasks and crop catalogue this centering could be fairly easily solved. But for screens like animals and inventory where the table holds the scrollbar it is not as easy. Let me know if there is interest in the top level centering here but it seems like we are maybe moving more towards the table views.
Jira link: LF-4948
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
pnpm i18nto help with this)