Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projects): main urls should not use project base path #196

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 7, 2025

Description

Some subproject URLs are re-written incorrectly.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher force-pushed the fix/projects/main-urls-should-not-use-project-base-path branch 6 times, most recently from 7a0f93e to 46f45ef Compare January 7, 2025 02:15
@ReenigneArcher ReenigneArcher force-pushed the fix/projects/main-urls-should-not-use-project-base-path branch from 46f45ef to 15f9d01 Compare January 7, 2025 02:21
@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 7, 2025 02:25
@ReenigneArcher ReenigneArcher merged commit 5ab313f into master Jan 7, 2025
10 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/projects/main-urls-should-not-use-project-base-path branch January 7, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant