Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging of system.defaults.CustomUserPreferences #1377

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

zhaofengli
Copy link
Contributor

@zhaofengli zhaofengli commented Mar 8, 2025

Without this, custom user preferences defined in different modules for the same domain aren't merged.

For example, the following config results in only UniversalSearchEnabled defined:

{
  imports = [
    {
      system.defaults.CustomUserPreferences = {
        "com.apple.Safari"."NSUserKeyEquivalents"."Quit Safari" = "@~q";
      };
    }
    {
      system.defaults.CustomUserPreferences = {
        "com.apple.Safari"."UniversalSearchEnabled" = false;
      };
    }
  ];
}

@zhaofengli zhaofengli force-pushed the fix-custom-user-preferences-merging branch from 5d058b8 to e33b016 Compare March 11, 2025 16:32
@zhaofengli zhaofengli force-pushed the fix-custom-user-preferences-merging branch from e33b016 to 814b503 Compare March 14, 2025 18:28
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution 🎉

@Enzime Enzime merged commit 9175b4b into LnL7:master Mar 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants