HAMSTR-819 : Escrow: Limit number of open (active) arbitration cases#17
Merged
jrkosinski merged 1 commit intoLoadPipe:multi-head-escrow-rdfrom Jul 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the new arbitration logic, the lifecycle of arbitration goes like this:
Proposal
A buyer or seller submits a proposal to either refund (to payer) or release (to receiver) a specific amount. At that point, it’s just a proposal.
Voting
Arbiters (those who are registered as arbiters for the escrow) vote on the proposal. When it reaches a certain number of ‘yes’ votes, it’s automatically set to “ACCEPTED” status. But it isn’t necessarily executed at that point.
Execution
Anyone can execute a proposal, IF it’s been accepted (if it’s status is ACCEPTED, that is, and if it still meets other criteria of still being relevant).
Currently, there is no limit on the number of arbitration cases that can be opened at once. There should be a limit, defined as a constant in ArbitrationModule.sol.
Changes: