HAMSTR-833: Proposer of Arbitration can Cancel before any Voting has been Done#18
Merged
jrkosinski merged 3 commits intomulti-head-escrow-rdfrom Aug 1, 2025
Merged
Conversation
HQS-Gun
approved these changes
Jul 31, 2025
HQS-Gun
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There should be a way to cancel arbitration, if nobody has voted on it, so as not to lock up other arbitration processes. Only the proposer of the arbitration should be able to do this though, and only if no votes have yet been cast.
Changes
In proposeArbitration, when a proposal is recorded, recorded also the proposer’s address (added new property to ArbitrationProposal)
Previously, a new proposal automatically got 1 vote for. This was supposed to represent the proposer casting a vote automatically. I got rid of that. Proposals start out with 0 votes for, 0 votes against (some tests will have to be adjusted once this change is made). UNLESS the proposer is also an arbiter - then the initial vote is recorded.
Modified cancelArbitration so that only the proposer is authorized to cancel, and only can cancel if no votes for or against have been cast (and the proposal isn’t ACCEPTED, REJECTED, or EXECUTED)
Added tests of the above logic
To Test