chore: fix all linting and compilation warnings

Logflare · Jan 20, 2023 · 5a018d1 · 5a018d1
1 parent 102d044
commit 5a018d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/src/parser.rs b/src/parser.rs
@@ -4187,7 +4187,7 @@ impl<'a> Parser<'a> {
             Token::Word(Word { value, keyword, .. })
                 if (dialect_of!(self is BigQueryDialect) && keyword == Keyword::OFFSET) =>
             {
-                return self.parse_function(ObjectName(vec![Ident::new(value)]));
+                self.parse_function(ObjectName(vec![Ident::new(value)]))
             }
             Token::Word(Word { value, keyword, .. }) if (keyword == Keyword::NoKeyword) => {
                 if self.peek_token() == Token::LParen {

diff --git a/tests/sqlparser_bigquery.rs b/tests/sqlparser_bigquery.rs
@@ -13,12 +13,9 @@
 #[macro_use]
 mod test_utils;
 
-use test_utils::*;
-
-use sqlparser::ast::Expr::{Identifier, MapAccess};
-use sqlparser::ast::SelectItem::UnnamedExpr;
 use sqlparser::ast::*;
 use sqlparser::dialect::{BigQueryDialect, GenericDialect};
+use test_utils::*;
 
 #[test]
 fn parse_literal_string() {
@@ -312,18 +309,19 @@ fn bigquery_and_generic() -> TestedDialects {
 #[test]
 fn parse_map_access_offset() {
     let sql = "SELECT d[offset(0)]";
-    let select = bigquery().verified_only_select(sql);
+    let _select = bigquery().verified_only_select(sql);
+    #[cfg(not(feature = "bigdecimal"))]
     assert_eq!(
-        select.projection[0],
-        UnnamedExpr(MapAccess {
-            column: Box::new(Identifier(Ident {
+        _select.projection[0],
+        SelectItem::UnnamedExpr(Expr::MapAccess {
+            column: Box::new(Expr::Identifier(Ident {
                 value: "d".to_string(),
                 quote_style: None,
             })),
             keys: vec![Expr::Function(Function {
                 name: ObjectName(vec!["offset".into()]),
                 args: vec![FunctionArg::Unnamed(FunctionArgExpr::Expr(Expr::Value(
-                    Value::Number("0".to_string(), false)
+                    Value::Number("0".into(), false)
                 ))),],
                 over: None,
                 distinct: false,