Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override hardcoded TEAMCITY_VERSION during image building process with build args #1

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@ FROM logicify/tomcat:latest
USER app
WORKDIR /srv/apache-tomcat

ENV TEAMCITY_VERSION 2017.2.1
ENV TEAMCITY_WEBAPP_PATH ROOT
ARG ARG_TEAMCITY_VERSION=2018.2.2
ARG ARG_TEAMCITY_WEBAPP_PATH=ROOT

ENV TEAMCITY_VERSION $ARG_TEAMCITY_VERSION
ENV TEAMCITY_WEBAPP_PATH $ARG_TEAMCITY_WEBAPP_PATH

ENV CATALINA_OPTS \
-Xms768m \
Expand Down