Skip to content

Ror sdk release11.7.0 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Ror sdk release11.7.0 #26

merged 2 commits into from
Apr 1, 2025

Conversation

indrasen715
Copy link
Collaborator

No description provided.

@indrasen715 indrasen715 merged commit 0dc75de into master Apr 1, 2025
1 of 2 checks passed
@indrasen715 indrasen715 requested a review from Copilot April 1, 2025 06:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the LoginRadius Ruby on Rails SDK by updating copyright dates, version numbers in documentation, and introducing a new set of webhook API endpoints with enhanced functionality.

  • Updated copyright headers from 2019 to 2025 across multiple files.
  • Revised the SDK version in README and CHANGELOG from 11.5.0 to 11.6.0.
  • Introduced new webhook API methods (create, update, delete, list, and get events) while deprecating legacy webhook endpoints.

Reviewed Changes

Copilot reviewed 43 out of 45 changed files in this pull request and generated 1 comment.

File Description
sdk/src/login_radius/lib/login_radius/api/authentication/*.rb Updated copyright headers.
sdk/src/login_radius/lib/login_radius/api/advanced/web_hook_api.rb Renamed and enhanced webhook API methods and updated documentation.
sdk/src/login_radius/README.md, CHANGELOG.md Updated version references and release notes.
Files not reviewed (2)
  • LICENSE: Language not supported
  • sdk/src/login_radius/LICENSE: Language not supported
Comments suppressed due to low confidence (1)

sdk/src/login_radius/lib/login_radius/api/advanced/web_hook_api.rb:4694

  • [nitpick] The webhook subscription model uses keys such as 'Headers', 'QueryParams', and 'Authentication'. Consider using a consistent naming convention (e.g. all lower-case keys like 'headers' and 'query_params') for clarity and consistency across the API.
"Headers"=> {"Custom-Header"=> "headerValue"},

Comment on lines +111 to +112
# @return Response Containing List of Webhhook Data
# 40.5
Copy link
Preview

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term 'Webhhook' appears to be a typo. Consider correcting it to 'Webhook'.

Suggested change
# @return Response Containing List of Webhhook Data
# 40.5
# @return Response Containing List of Webhook Data

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant