OSOE-646: Remove CustomEditAsync #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
requested changes
Nov 27, 2023
|
|
||
| namespace Lombiq.OrchardCoreApiClient; | ||
|
|
||
| public class ApiClientBase<T> : IDisposable |
There was a problem hiding this comment.
This is not an abstract class (it shouldn't be) so the *Base name is not appropriate. You can name it e.g. just ApiClient. Also, use a less generic name for the type parameter, like TApi.
There was a problem hiding this comment.
The non-generic ApiClient should remain, that's still useful as a default.
There was a problem hiding this comment.
The non-generic client is named OrchardCoreApiClient, it should be ApiClient (since this is a usual pattern and also would prevent adding a breaking change).
Piedone
requested changes
Nov 27, 2023
Piedone
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-646
Fixes #30