Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Laravel 12 🎉 #150

Closed
wants to merge 2 commits into from

Conversation

15g-lucas
Copy link

@15g-lucas 15g-lucas commented Feb 25, 2025

This PR updates the configuration files for laravel 12

closes #149

Summary by CodeRabbit

  • Chores
    • Expanded compatibility testing to include Laravel version 12.
    • Updated dependency requirements to support Laravel version 12 and PHPUnit version 12.

Copy link
Contributor

coderabbitai bot commented Feb 25, 2025

Walkthrough

The CI workflow and dependency configuration have been updated to support Laravel version 12 and PHPUnit version 12. In the CI workflow file, the Laravel matrix has been expanded to include "^12.0". In the composer.json file, the version constraints for laravel/framework, orchestra/testbench, and phpunit/phpunit have been updated to include their respective "^12.0" and "^10.0" versions. There are no changes to exported or public entities.

Changes

File Change Summary
.github/workflows/tests.yml Added Laravel version "^12.0" to the matrix configuration for CI testing.
composer.json Expanded dependency version ranges to include "^12.0" for laravel/framework, "^10.0" for orchestra/testbench, and "^12.0" for phpunit/phpunit.

Poem

I hop with cheer in my code-filled land,
Where new versions join, so fresh and grand,
Laravel twelve skips into the test parade,
PHPUnit twelve marches, perfectly arrayed,
I'm a joyful rabbit, celebrating each line—
Bounding through changes, feeling just fine! 🐰


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 580d57a and 4c174ea.

📒 Files selected for processing (1)
  • composer.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • composer.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@15g-lucas
Copy link
Author

👋I've updated testbench in the dev dependencies

@GautierDele
Copy link
Member

GautierDele commented Feb 28, 2025

I'll drop Laravel 10 for #114
Seems like someting in Laravel 12 has broke the package also

@GautierDele
Copy link
Member

I'm on it, there is a change in Laravel 12 how chunking works, which make the package break

@GautierDele
Copy link
Member

Fixed in #152

@GautierDele GautierDele closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package does not work on Laravel 12
2 participants