made the Storage permission #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Irtesaam can you check now i have implemented this in my emulator as well as 2 other phones and it is asking for the storage permission |
Contributor
Author
|
Dont merge it now i have to make minor changes |
Irtesaam
requested changes
Aug 16, 2025
Collaborator
Irtesaam
left a comment
Irtesaam
left a comment
There was a problem hiding this comment.
@FireFistisDead The current logic is flawed as app continues to save files to the Downloads directory even after storage permission has been denied. This behavior violates user privacy so fix it ASAP.
Also, why was access to music and audio added? Any app features actually using this permission?
Contributor
Author
|
@Irtesaam no review it previous commits were just my fault |
Contributor
Author
When Permission givenWhatsApp.Video.2025-08-16.at.23.56.36_c7f269be.mp4 |
Contributor
Author
When Permission is not givenpermission_not_given.mp4@Irtesaam fixeeed this flaw |
Irtesaam
reviewed
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Closes #127
Description
This pull request introduces improvements to how storage permissions are handled in the Android app, refactors permission logic for better maintainability, and updates build configuration. The main changes include switching to a centralized permissions helper, updating Android manifest permissions, and modifying the NDK version in the build configuration.
Permissions handling and refactoring:
ExportScheduleUtilitywith a call toPermissionsHelper.requestStoragePermission, ensuring consistent permission management across the app (src/utils/exportSchedule.ts).requestStoragePermissioninsrc/utils/storage-permissions.tsthat delegates permission handling toPermissionsHelperfor easier reuse and testing.PermissionsHelperintoexportSchedule.tsfor centralized permission logic.Android configuration:
android.permission.WRITE_EXTERNAL_STORAGEtoAndroidManifest.xmlto explicitly request storage access on Android devices.android/build.gradlefrom27.1.12297006to26.3.11579264for compatibility or build stability.Files Changed
GSSoC Contributor
Testing Device