-
Notifications
You must be signed in to change notification settings - Fork 12
Feature of csv file rename #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Irtesaam check this it is now perfect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FireFistisDead I tested it with all three Android versions (11,13 and 16) as you can check in this Video
While the permission prompt appears correctly on all versions and the permission is shown as granted, the save operation only succeeds on Android 11. On Android 13 and 16, attempts to save the CSV fail with a “permission denied” error despite the permission being allowed, as shown in the screenshots and video.
Resolve this issue before I merge as download failing even after all permissions are granted will lead to unexpected behavior.
|
@Irtesaam that permission are for music and audio which is required to implement the android 13+ bug which is there actually I resolving this issue in other branch ig by mistake this permission are asking in android 13+ this PR is mainly for Android 13- to rename the csv I am working on that bug on the other branch sorry for the inconvenience |
|
And those permission which are given will not cause any unexpected behaviour |
Irtesaam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FireFistisDead Alright then. Since the rename functionality is working as expected, I am merging this PR. Make resolving the Android 13+ permission issue your next priority.
Overall, great work so far !!
|
@Irtesaam thanks and yeah I'm currently working on that only will update you soon with a solution |
Fixes
Rename of the csv schedule
Closes #126
Description
This pull request introduces improvements to the export functionality and state management in the app, primarily enabling users to specify a custom filename when exporting schedules to CSV. It also adds a new state variable for managing which registers are being viewed, and updates Android permissions for better compatibility with newer versions. The most important changes are grouped below:
Export Functionality Enhancements
SettingsScreen.tsxfor user input and changes to the export utility to handle the filename. (src/screens/user-settings/SettingsScreen.tsx,src/utils/exportSchedule.ts) [1] [2] [3] [4] [5] [6] [7] [8] [9]saveScheduleToDeviceWithNameto support exporting with a custom filename. (src/utils/exportSchedule.ts)State Management Improvements
viewingRegistersstate and corresponding setter to the global store, allowing the app to track which registers are currently being viewed. This state is updated appropriately when registers are deleted. (src/store/store.ts) [1] [2] [3] [4] [5]SettingsScreen.tsxto utilize the newviewingRegistersandsetViewingRegistersfor improved register selection logic. (src/screens/user-settings/SettingsScreen.tsx)Android Permissions Update
AndroidManifest.xmlto add new permissions for reading media files on Android 13+ and clarified usage ofMANAGE_EXTERNAL_STORAGE, improving compatibility and security. (android/app/src/main/AndroidManifest.xml)Files Changed
GSSoC Contributor
Testing Device