Skip to content

Conversation

@FireFistisDead
Copy link
Contributor

Fixes

Rename of the csv schedule
Closes #126

Description

This pull request introduces improvements to the export functionality and state management in the app, primarily enabling users to specify a custom filename when exporting schedules to CSV. It also adds a new state variable for managing which registers are being viewed, and updates Android permissions for better compatibility with newer versions. The most important changes are grouped below:

Export Functionality Enhancements

  • Added support for specifying a custom filename when exporting schedules to CSV. This includes a new modal in SettingsScreen.tsx for user input and changes to the export utility to handle the filename. (src/screens/user-settings/SettingsScreen.tsx, src/utils/exportSchedule.ts) [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Added a new function saveScheduleToDeviceWithName to support exporting with a custom filename. (src/utils/exportSchedule.ts)

State Management Improvements

  • Added a new viewingRegisters state and corresponding setter to the global store, allowing the app to track which registers are currently being viewed. This state is updated appropriately when registers are deleted. (src/store/store.ts) [1] [2] [3] [4] [5]
  • Updated usages in SettingsScreen.tsx to utilize the new viewingRegisters and setViewingRegisters for improved register selection logic. (src/screens/user-settings/SettingsScreen.tsx)

Android Permissions Update

  • Updated AndroidManifest.xml to add new permissions for reading media files on Android 13+ and clarified usage of MANAGE_EXTERNAL_STORAGE, improving compatibility and security. (android/app/src/main/AndroidManifest.xml)

Files Changed

GSSoC Contributor

  • Yes, I am a GSSoC contributor

Testing Device

  • Physical Android Device

@FireFistisDead
Copy link
Contributor Author

@Irtesaam check this it is now perfect

@FireFistisDead FireFistisDead changed the title Feature/csv filename Feature of csv file rename Aug 18, 2025
Copy link
Collaborator

@Irtesaam Irtesaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FireFistisDead I tested it with all three Android versions (11,13 and 16) as you can check in this Video

While the permission prompt appears correctly on all versions and the permission is shown as granted, the save operation only succeeds on Android 11. On Android 13 and 16, attempts to save the CSV fail with a “permission denied” error despite the permission being allowed, as shown in the screenshots and video.

Screenshot From 2025-08-19 15-57-41 Screenshot From 2025-08-19 16-03-04

Resolve this issue before I merge as download failing even after all permissions are granted will lead to unexpected behavior.

@FireFistisDead
Copy link
Contributor Author

@Irtesaam that permission are for music and audio which is required to implement the android 13+ bug which is there actually I resolving this issue in other branch ig by mistake this permission are asking in android 13+ this PR is mainly for Android 13- to rename the csv I am working on that bug on the other branch sorry for the inconvenience

@FireFistisDead
Copy link
Contributor Author

And those permission which are given will not cause any unexpected behaviour

Copy link
Collaborator

@Irtesaam Irtesaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FireFistisDead Alright then. Since the rename functionality is working as expected, I am merging this PR. Make resolving the Android 13+ permission issue your next priority.

Overall, great work so far !!

@Irtesaam Irtesaam merged commit aa1db64 into Loop-Hive:main Aug 19, 2025
6 checks passed
@FireFistisDead
Copy link
Contributor Author

@Irtesaam thanks and yeah I'm currently working on that only will update you soon with a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] To make a feature of rename the csv file of schedule

2 participants