Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add linter CI and lint all codes #156

Merged
merged 17 commits into from
Dec 3, 2024
Merged

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 2, 2024

Fully test on my fork. You can check https://github.com/XMLHexagram/rune/actions/runs/12126259207 .

Summary by Sourcery

CI:

  • Add a new GitHub Actions workflow for linting Rust and Flutter code, including setup for toolchains and dependencies.

@XMLHexagram XMLHexagram requested a review from Losses December 2, 2024 19:30
Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This PR adds linting configuration and CI workflows for both Rust and Flutter code. The changes include setting up GitHub Actions for code analysis, adding rustfmt configuration, and reformatting existing code to comply with Rust's formatting standards. The main focus is on code style consistency and automated quality checks.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added GitHub Actions workflow for linting
  • Created new linter.yml workflow file
  • Configured separate jobs for Rust and Flutter analysis
  • Set up dependency installation steps for both Rust and Flutter
  • Added steps for running cargo fmt, clippy, and Flutter analyze
.github/workflows/linter.yml
Added Rust formatting configuration
  • Created rustfmt configuration file
  • Configured to ignore generated message files
.rustfmt.toml
Reformatted Rust code to match style guidelines
  • Fixed function parameter line wrapping
  • Adjusted indentation and line breaks
  • Reorganized module imports
  • Removed trailing whitespace
  • Fixed line endings
metadata/src/reader.rs
migration/src/m20230728_000008_create_media_cover_art_table.rs
cli/src/main.rs
database/src/actions/index.rs
metadata/src/lib.rs
playback/src/lib.rs
playback/src/output_stream.rs
analysis/src/analyzer/cpu_sub_analyzer.rs
native/hub/src/sfx.rs
analysis/src/analyzer/gpu_sub_analyzer.rs
database/src/actions/analysis.rs
database/src/connection.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@XMLHexagram
Copy link
Collaborator Author

Well, it just works.

@Losses Losses merged commit 8345391 into Losses:master Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants