Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(macOS): Add zip release #157

Merged
merged 3 commits into from
Dec 3, 2024
Merged

ci(macOS): Add zip release #157

merged 3 commits into from
Dec 3, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 2, 2024

Summary by Sourcery

CI:

  • Add steps to upload and release macOS ZIP artifacts in the CI workflow.

Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This PR adds ZIP file release support for macOS builds alongside the existing DMG format. The implementation modifies the CI workflow to create, sign, and upload ZIP artifacts, while maintaining the existing DMG release process.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added ZIP artifact upload and release process in CI workflow
  • Added new upload-artifact step for ZIP files
  • Added ZIP file renaming step for releases
  • Added new release action step for ZIP artifacts
  • Maintained parallel DMG release process
.github/workflows/build.yml
Modified DMG creation script to simplify volume naming
  • Removed SHA from volume name
  • Made REF_NAME optional in volume naming
  • Updated file naming pattern to match new convention
scripts/macos_6_create_dmg.sh
Updated code signing and notarization process to handle ZIP creation
  • Added cleanup of temporary ZIP file after notarization
  • Added creation of final ZIP archive after stapling
  • Maintained existing notarization process
scripts/macos_5_codesign_and_notarize.sh
Enhanced Justfile configuration
  • Added dotenv-load setting for environment variable support
Justfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@XMLHexagram XMLHexagram requested a review from Losses December 2, 2024 23:59
@Losses Losses merged commit 98863a2 into master Dec 3, 2024
2 checks passed
@XMLHexagram XMLHexagram deleted the macos-zip-release branch December 3, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants