Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): resolve filename conflict and remove nested ZIP structure for DMG #160

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix(macos): resolve filename conflict and remove nested ZIP structure for DMG #160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8a2a17
ci(macos): resolve artifact filename conflict for MacOS ZIP upload
Ovler-Young Dec 3, 2024
a437dd1
refactor(macos): remove nested ZIP structure for DMG artifacts
Ovler-Young Dec 3, 2024
9535f95
ci(macos): correct duplicate directory path in DMG artifact upload
Ovler-Young Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,17 +383,26 @@ jobs:
install_name_tool -change /opt/homebrew/opt/lmdb/lib/liblmdb.dylib @executable_path/../Frameworks/liblmdb.dylib Rune.app/Contents/MacOS/Rune
working-directory: build/macos/Build/Products/Release

- name: Rename DMG
run: |
mv temp_macos/*.dmg "temp_macos/Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.dmg"

- name: Rename ZIP
run: |
mv temp_macos/*.zip "temp_macos/Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.zip"

- name: Upload artifact macOS DMG
uses: actions/upload-artifact@v4
with:
path: "temp_macos/*.dmg"
name: Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS
path: temp_macos/Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.dmg
name: Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.dmg

- name: Upload artifact macOS ZIP
continue-on-error: true
uses: actions/upload-artifact@v4
with:
path: "temp_macos/*.zip"
name: Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS
path: temp_macos/Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.zip
name: Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.zip

- name: Clean up
if: ${{ always() }}
Expand All @@ -404,16 +413,6 @@ jobs:
security delete-keychain $RUNNER_TEMP/rune-signing.keychain-db
fi
rm -f .env

- name: Rename DMG
if: startsWith(github.ref, 'refs/tags/v')
run: |
mv temp_macos/*.dmg "temp_macos/Rune-${{ github.ref_name }}-macOS.dmg"

- name: Rename ZIP
if: startsWith(github.ref, 'refs/tags/v')
run: |
mv temp_macos/*.zip "temp_macos/Rune-${{ github.ref_name }}-macOS.zip"

- name: Release DMG
uses: ncipollo/release-action@v1
Expand Down
Loading