-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Build instructions for macOS. #163
Conversation
Reviewer's Guide by SourceryThis PR adds a new BUILD.md file with detailed instructions for building the Rune project on macOS. The documentation includes prerequisites, step-by-step build instructions, and important notes about code signing configuration for both regular contributors and Inkwire Tech employees. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @laosb - I've reviewed your changes - here's some feedback:
Overall Comments:
- The clone command is missing in step 1. Please add the actual git clone command with the repository URL.
- Consider moving Inkwire Tech employee-specific instructions to internal documentation to maintain a cleaner separation between public and private documentation.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
### Steps | ||
|
||
1. Clone the repository: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Missing repository URL or clone command
Please provide the git clone command with the repository URL to help users get started.
Summary by Sourcery
Documentation: