Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Traffic lights reset after showing file seletor #168

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 3, 2024

Summary by Sourcery

Fix the macOS traffic lights reset issue by refactoring the directory path selection logic and introducing a new utility function to manage macOS-specific behavior.

Bug Fixes:

  • Fix the issue where traffic lights reset after showing the file selector on macOS by adjusting the window control button manager.

Enhancements:

  • Refactor the directory path selection logic by introducing a new utility function 'getDirPath' to handle macOS-specific behavior.

Copy link

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

This PR fixes a macOS-specific issue where the traffic light buttons (window control buttons) reset their position after showing a file selector dialog. The implementation introduces a new utility function that wraps the directory selection functionality and ensures proper button positioning on macOS.

Class diagram for the new getDirPath utility function

classDiagram
    class getDirPath {
        +Future<String?> getDirPath()
    }
    class MacOSWindowControlButtonManager {
        +setVertical()
    }
    getDirPath --> MacOSWindowControlButtonManager : uses
    note for getDirPath "This function wraps the directory selection and adjusts button positioning on macOS."
Loading

File-Level Changes

Change Details Files
Created a new utility function to handle directory path selection with macOS-specific behavior
  • Implemented getDirPath() wrapper function around getDirectoryPath()
  • Added macOS-specific code to reset traffic light button position after dialog closes
lib/utils/get_dir_path.dart
Updated directory selection calls across the application
  • Replaced direct getDirectoryPath() calls with getDirPath()
  • Updated imports to use the new utility function
lib/screens/home/widgets/welcome.dart
lib/screens/settings_library/widgets/add_library_setting_button.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

lib/utils/get_dir_path.dart Show resolved Hide resolved
@Losses Losses merged commit 22fb4da into master Dec 4, 2024
2 checks passed
@Losses Losses deleted the fix-traffic-light branch December 4, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants