Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Add 2px to album offset for visual alignment #170

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(macOS): Add 2px to album offset for visual alignment #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/screens/query_tracks/query_tracks.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ class _QueryTracksPageState extends State<QueryTracksPage> {
if (!isMini)
Padding(
padding: Platform.isMacOS
? const EdgeInsets.fromLTRB(24, 54, 24, 12)
// The left offset on macOS should be the same as the naviagtion_bar's parent title left offset
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Fix typo in comment: 'naviagtion_bar' should be 'navigation_bar'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate you

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback, we will generate fewer comments like this in the future according to the following instructions:

- Exclude comments that only address minor typos or nitpicks unless they significantly impact code readability or functionality.

// But due to font and typography reasons(#166), we need to add 2px to visually align them.
? const EdgeInsets.fromLTRB(26, 54, 24, 12)
: const EdgeInsets.fromLTRB(20, 54, 24, 12),
child: Transform.scale(
scale: 1.2,
Expand Down
Loading