Synchronize animations with Timeline position#42
Merged
Luca3317 merged 8 commits intoLuca3317:mainfrom Feb 2, 2026
Merged
Conversation
added 5 commits
February 20, 2025 10:19
Closed
Owner
|
Only got around to checking this out now, looks really good! Thanks for the contribution :)
No I agree, the behaviour you implemented is much preferable. I hadnt spent a lot of time or thought on the animation clips before since I was mostly focused on the mesh modifiers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeline Integration Improvements
To achieve this, the behavior of TMP Animator was altered such that when animating via Timeline, the update mode is considered to be UpdateMode.Script.
Two options have been added to the TMPAnimatorTrack inspector.
I believe all this to be objectively desirable, but if maximizing preservation of current (somewhat buggy?) behaviour is a priority then I can add a check box to the track Inspector that toggles the core UpdateMode change.
Future Improvements
Ideally I'd like there to be options on the Track for how to handle inline styles while the timeline is playing (ie. ignore any inline animations, allow but reset their timing on timeline start, allow and sync them with timeline or allow them to run independently) but implementing these kind of options would require much deeper changes and unfortunately I don't have the time for it.