fix: Add missing originalTitle property in responses #74
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughA new property, Changes
Poem
Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)src/paths/status/sessions.yaml (2)
I must say, the implementation is most proper and well-placed within the schema. The type declaration and example value are absolutely spot-on, if I do say so myself.
I do beg your pardon, but I couldn't help but notice that the description of this most excellent property varies across different parts of our specification, as previously observed. Might I suggest we maintain consistency by adopting a standardized description throughout? If you'll permit me, I shall examine the current state of affairs: #!/bin/bash
# Description: Verify consistency of originalTitle descriptions across the specification
echo "=== Examining originalTitle descriptions across the specification, sir ==="
rg -A 1 "originalTitle:" --type yaml
echo -e "\n=== And now, the Metadata model definition, if you please ==="
cat src/models/MetaData.yaml 2>/dev/null || echo "My sincerest apologies, but I cannot locate the Metadata model file, sir."Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
If the response of /sessions in this case has that entire
It goes: plex-api-spec/src/pms-spec.yaml Lines 248 to 249 in a994a85 To the response here: So it should work, it's most likely the publishing issues |
|
Thanks for the clarification. /sessions response does not have the entirety of the Metadata model so that makes sense why its a hardcoded subset. The current |
|
Anyone mind if I merge this in? |
@JasonLandbridge Nope go ahead, LGTM |
@JasonLandbridge I see that
originalTitleis already added (by you) in theMetadatamodel but it's unclear if this is not present in https://github.com/LukeHagar/plexjs due to npm publishing issues or because I'm misunderstanding how models vs. paths work here -- why doesn't the spec use the models in path responses, rather than hardcoding the responses for each path?If I need to add
originalTitleto other paths where Metadata is used I can add more commits, just confused about why its already in the spec but not used.Fixes #72
Summary by CodeRabbit
originalTitleproperty in the session metadata, providing additional context for non-English media items or audio tracks.