-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New preload #1895
base: dev
Are you sure you want to change the base?
New preload #1895
Conversation
Move all file processor and decoder into the preload stage. The data will be saved to a new data structure called 'packet' When replay, the vulkan replay consumer will process those packets directly. The new preload only works for vulkan API
Author zehao-jing-arm not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Please have a look at this patch :) |
auto* preload_processor = dynamic_cast<decode::PreloadFileProcessor*>(file_processor_); | ||
GFXRECON_ASSERT(preload_processor) | ||
preload_processor->PreloadNextFrames(preload_frames_count); | ||
if (detected_vulkan_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detection and processing of API is handled in other parts of the system by having vectors of classes that may or may not take responsibility of blocks. E.g. there are different Decoder and the FileProcessor walks a list of Decoders to decode and then consume blocks. This hardcoding is counter to that design. PreloadAllocator should fit into that design in some way that does not detect or hardcode API types in Application class.
CI gfxreconstruct build queued with queue ID 367638. |
CI gfxreconstruct build # 6038 running. |
CI gfxreconstruct build # 6038 failed. |
Move all file processor and decoder into the preload stage. The data will be saved to a new data structure called 'packet' When replay, the vulkan replay consumer will process those packets directly.
The new preload only works for vulkan API