Support multi-window replay on Android

[qiq-2022]

Introduce JAVA layer into gfxreconstruct
to enable replay multi-window trace files on Android. The command line changes to
am start -n "com.lunarg.gfxreconstruct.replay/.ReplayActivity"

[ci-tester-lunarg]

Author qiq-2022 not on autobuild list. Waiting for curator authorization before starting CI build.

[CLAassistant]

All committers have signed the CLA.

[ziga-lunarg]

In android/scripts/gfxrecon.py the app_activity should be updated

[ci-tester-lunarg]

CI gfxreconstruct build queued with queue ID 323055.

[ci-tester-lunarg]

CI gfxreconstruct build # 5549 running.

[ci-tester-lunarg]

CI gfxreconstruct build # 5549 failed.

[bradgrantham-lunarg]

I think this probably also needs changes in android/scripts/gfxrecon.py to alter the way it invokes the replay Activity.

[ci-tester-lunarg]

Author qiq-2022 not on autobuild list. Waiting for curator authorization before starting CI build.

[qiq-2022]

Hi, I have modified the activity name in android/scripts/gfxrecon.py.

[ci-tester-lunarg]

CI gfxreconstruct build queued with queue ID 323522.

[ci-tester-lunarg]

CI gfxreconstruct build # 5556 running.

[ci-tester-lunarg]

CI gfxreconstruct build # 5556 failed.

[ci-tester-lunarg]

Author qiq-2022 not on autobuild list. Waiting for curator authorization before starting CI build.

[antonio-lunarg]

I've tested this on a device with a notch, and I noticed the replay does not extend over the cutout area.

To fix that, I had to add a res/values-v27/styles.xml with the following content:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <style name="AppTheme" parent="@android:style/Theme.NoTitleBar.Fullscreen">
        <item name="colorPrimary">@color/colorPrimary</item>
        <item name="colorPrimaryDark">@color/colorPrimaryDark</item>
        <item name="colorAccent">@color/colorAccent</item>

        <item name="android:windowLayoutInDisplayCutoutMode">shortEdges</item>
        <item name="android:windowTranslucentStatus">true</item>
        <item name="android:windowTranslucentNavigation">true</item>
    </style>
</resources>

[ci-tester-lunarg]

Author qiq-2022 not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author qiq-2022 not on autobuild list. Waiting for curator authorization before starting CI build.

[antonio-lunarg]

Thanks for the updates! Once my last comment is resolved, LGTM.

[ci-tester-lunarg]

Author qiq-2022 not on autobuild list. Waiting for curator authorization before starting CI build.

[MarkY-LunarG]

@qiq-2022 , I ran this on my Pixel 6 with Android 13 (even with Antonio's change) and I only see half of the screen. I believe @per-mathisen-arm mentioned there were issues pre Android 14, but I thought he mentioned you had fixes for that. Do you have suggestions? Thanks

Update It looks like it's because the application is launching in portrait mode on my phone. If I manually rotate it, the image looks correct.

[qiq-2022]

@MarkY-LunarG

It looks like it's because the application is launching in portrait mode on my phone. If I manually rotate it, the image looks correct.

Yes that's true. This problem comes from the existing way of changing orientation. Simply call "setRequestedOrientation" after the first window created will leads to this issue. If we only set the orientation at the very beginning, it will not have this problem.

My proposal is to fix the app orientation to landscape since most traces are captured in landscape mode. And provide an option that can make the app replay in portrait mode. Otherwise, it will have to fix the way of changing orientation during replay.

I actually raised an issue for awareness: #1945

[MarkY-LunarG]

We actually have a combination of portrait and landscape mode captures. This is because we capture Android GUI as well since it uses SKIA with Vulkan. So we need to be able to dynamically switch based on the capture.

[MarkY-LunarG]

I'm not sure if this is the fix, but if I add the following in ReplayActivity.java, it seems to work on the few tests I've tried:

In ReplayActivity.java, addNewView, right after System.loadLibrary:

                if (width > height) {
                    setRequestedOrientation(0);
                } else {
                    setRequestedOrientation(1);
                }

I don't know if:

1. We need to wrap this in an Android version check
2. If this will really work with portrait tests.

I have to do more testing. But I'll let you know.

[MarkY-LunarG]

I'm not sure if this is the fix, but if I add the following in ReplayActivity.java, it seems to work on the few tests I've tried:

In ReplayActivity.java, addNewView, right after System.loadLibrary:

                if (width > height) {
                    setRequestedOrientation(0);
                } else {
                    setRequestedOrientation(1);
                }

I don't know if:

1. We need to wrap this in an Android version check

2. If this will really work with portrait tests.

I have to do more testing. But I'll let you know.

Nope. That worked for landscape captures when the device was locked in portrait mode, but not portrait captures.

[ci-tester-lunarg]

CI gfxreconstruct build queued with queue ID 367637.

[ci-tester-lunarg]

CI gfxreconstruct build # 367637 cancelled.