Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDR: Initialize multiview flag #2014

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

roberto-c
Copy link
Contributor

Missing variable initialization was causing multiview structure to be added when creating render passes even when there was not multiview in play.

@ci-tester-lunarg
Copy link

Author roberto-c not on autobuild list. Waiting for curator authorization before starting CI build.

Missing variable initialization was causing multiview structure to be
added when creating render passes even when there was not multiview in
play.
@ci-tester-lunarg
Copy link

Author roberto-c not on autobuild list. Waiting for curator authorization before starting CI build.

@roberto-c
Copy link
Contributor Author

Without the multiview variable initialization, a crash could happen because a VkRenderPassMultiviewCreateInfo was being added incorrectly when creating a render pass in CloneRenderPass due invalid vaue.

if (original_render_pass->has_multiview)

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 367634.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6036 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6036 passed.

@bradgrantham-lunarg bradgrantham-lunarg merged commit 5150466 into LunarG:dev Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants