Map depth image in Unorm16 for full range #2016
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping from Unorm16 encoded depth images did map half of the range to the max color value, hence causing that the same gray tones were used twice, for values < 0.5 (0x8000 before unorm), or >= 0.5. Fixing the normalization to linearly map the whole range.
|
Author dfriederich not on autobuild list. Waiting for curator authorization before starting CI build. |
|
With this fix: |
|
CI gfxreconstruct build queued with queue ID 367658. |
|
I tried copying how it looked before, but somehow I fail (maybe some company firewall, but it did let me add the image above, odd). Anyhow, before this PR, the middle grays in the image above were dark black, then immediately afterwards some white area. While it is interesting to see the specific depth of 0x8000 so clearly, it did confuse me, I did not understand where this black to white border in some of the part of the image is from. |
|
(restarted the browser. This is how it looks without this PR)
|
|
CI gfxreconstruct build # 6039 running. |
|
CI gfxreconstruct build # 6039 failed. |
|
This failed because of a reference image difference, as expected. I'll
leave this to Panos for his Monday to approve and merge and update
reference files or I can as well. -Brad
…On Fri, Feb 7, 2025, 4:06 PM LunarG CI robot ***@***.***> wrote:
CI gfxreconstruct build # 6039 failed.
—
Reply to this email directly, view it on GitHub
<#2016 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMCLT7ZC7UXIWHLB7KUFXCT2OVDBVAVCNFSM6AAAAABWWZECKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUGM2TENZYGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping from Unorm16 encoded depth images did map half of the range to the max color value, hence causing that the same gray tones were used twice, for values < 0.5 (0x8000 before unorm), or >= 0.5. Fixing the normalization to linearly map the whole range.