Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update console #3

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Update console #3

merged 1 commit into from
Dec 9, 2024

Conversation

flupke
Copy link
Contributor

@flupke flupke commented Dec 9, 2024

This fixes build errors on wasm targets:

error[E0659]: `wants_emoji` is ambiguous
  --> /home/flupke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-0.13.0/src/utils.rs:7:19
    |
7   | use crate::term::{wants_emoji, Term};
    |                   ^^^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple glob imports of a name in the same module
note: `wants_emoji` could refer to the function imported here
  --> /home/flupke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-0.13.0/src/term.rs:560:9
    |
560 | pub use crate::unix_term::*;
    |         ^^^^^^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `wants_emoji` to disambiguate
note: `wants_emoji` could also refer to the function imported here
  --> /home/flupke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-0.13.0/src/term.rs:562:9
    |
562 | pub use crate::wasm_term::*;
    |         ^^^^^^^^^^^^^^^^^^^
    = help: consider adding an explicit import of `wants_emoji` to disambiguate

This fixes build errors on wasm targets:

    error[E0659]: `wants_emoji` is ambiguous
      --> /home/flupke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-0.13.0/src/utils.rs:7:19
        |
    7   | use crate::term::{wants_emoji, Term};
        |                   ^^^^^^^^^^^ ambiguous name
        |
        = note: ambiguous because of multiple glob imports of a name in the same module
    note: `wants_emoji` could refer to the function imported here
      --> /home/flupke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-0.13.0/src/term.rs:560:9
        |
    560 | pub use crate::unix_term::*;
        |         ^^^^^^^^^^^^^^^^^^^
        = help: consider adding an explicit import of `wants_emoji` to disambiguate
    note: `wants_emoji` could also refer to the function imported here
      --> /home/flupke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-0.13.0/src/term.rs:562:9
        |
    562 | pub use crate::wasm_term::*;
        |         ^^^^^^^^^^^^^^^^^^^
        = help: consider adding an explicit import of `wants_emoji` to disambiguate
Copy link
Owner

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Luni-4 Luni-4 merged commit f18fc5f into Luni-4:master Dec 9, 2024
3 of 5 checks passed
@flupke
Copy link
Contributor Author

flupke commented Dec 9, 2024

Thanks a lot for the swift release!

@Luni-4
Copy link
Owner

Luni-4 commented Dec 9, 2024

Thanks to you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants