GH-598: second QA fix - first review #728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 8, 2025 00:03
utkarshg6
reviewed
Oct 9, 2025
| } | ||
|
|
||
| pub fn acknowledge_scan_error(&mut self, error: &ScanError, logger: &Logger) { | ||
| debug!(logger, "Acknowledging a scan that couldn't finish"); |
Collaborator
There was a problem hiding this comment.
Perhaps you could add more details to this log, using the contents of the error.
utkarshg6
approved these changes
Oct 9, 2025
* Fixed the AddRouteResultMessage panic problem too * Preemptive review issues * Formatting * example.com -> www.example.com * Formatting * Added some debug logging to track RRI * Formatting * Clippy * Made RRI logs more consistent and increased straggler timeout to 30s * Typo corrections * Interim commit * Tests pass * Unit tests pass * Interim commit: a real mess * Proxy Server tests passing; some cleanup yet to do * Unit tests are all passing * Unit and multinode tests pass * All the tests pass now * Tests passing except one in proxy_client * RRIDs are completely gone; hostnames are mandatory. * MOre review issues * Review issues * Test is passing now, and code is cleaner * Cleaned up some code * More review issues * Formatting * Added packet describers * Error message change. * log messages enhanced of StreamKey --------- Co-authored-by: czarte <[email protected]>
* update ci-matrix to test new runners * Revert Windows runner in CI matrix Moving windows runner back to 2022, so we can allow macos-latest to fully run through Actions
* Refine regex for max block count extraction and add test Updated regex to capture maximum block count from error messages more accurately - namely update to Nodies provider. Added a new test case for extracting this specific error response. * Fix inclusive range calculation for block scanning in BlockchainInterfaceWeb3 Adjusted the end block marker calculation to correctly account for inclusive ranges by subtracting 1 from the scan range. T * Fix block marker calculations in tests for blockchain bridge and interface. Adjusted expected new start block values to ensure accurate transaction retrieval and logging.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
|
|
||
| pub fn acknowledge_scan_error(&mut self, error: &ScanError, logger: &Logger) { | ||
| debug!(logger, "Acknowledging a scan that couldn't finish"); |
There was a problem hiding this comment.
Bug: Insufficient logging detail in scan error handler (Bugbot Rules)
The debug log in acknowledge_scan_error logs a generic message without including error details. The PR reviewer explicitly requested adding more details using the contents of the error parameter, which contains scan_type, response_skeleton_opt, and msg fields that would aid debugging. The commit adds the log but doesn't incorporate the error's contents as requested.
* GH-827: add boilerplate code * GH-827: introduce new logic * GH-827: some renamings for clarity * GH-827: fix test estimate_transaction_fee_total_works_for_retry_txs * GH-827: refactor test estimate_transaction_fee_total_works_for_retry_txs * GH-827: fix test returns_correct_priced_qualified_payables_for_retry_payable_scan * GH-827: fix test blockchain_interface_web3_can_introduce_blockchain_agent_in_the_retry_payables_mode * GH-827: fix 2 more tests * GH-827: refactor retry_payables_gas_price_ceiling_test_of_border_value_if_the_previous_attempt_being_bigger * GH-827: review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors gas price computation and retry strategy, hardens/reschedules scans (incl. receivables), renames pending-failure terminology, tweaks blockchain/web3 handling, and updates CI/tests.
DEFAULT_GAS_PRICE_MARGINwithDEFAULT_GAS_PRICE_RETRY_PERCENTAGEand addDEFAULT_GAS_PRICE_RETRY_CONSTANT.increase_gas_price_by_margin→increase_by_percentage; adjust pricing of new/retry txs (retry: percentage if latest≥prev, else add constant).UnableToStartScanner(replacingPayableSequenceScanner) and add explicit handling forReceivables.time_until_next_scan→compute_time_to_next_scan;reset_scan_timer(&Logger).end = start + range - 1); update new start-block math.transaction_count(address, None); add nonce logging.macos-latest.Written by Cursor Bugbot for commit 422038f. This will update automatically on new commits. Configure here.