Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible checking #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

More flexible checking #8

wants to merge 5 commits into from

Conversation

DerFlash
Copy link
Contributor

  • on default it still checks globally on proxy login
  • when enabling the 'checkForServersOnly' list it will only check if the player tries to connect to one of the servers specified
  • I've also provided a pom.xml which should help other people like me importing the project and contributing to it

Kind regards
DerFlash

* on default it still checks globally on proxy login
* when enabling the 'checkForServersOnly' list it will only check if the player tries to connect to one of the servers specified
@DerFlash
Copy link
Contributor Author

Some further information about the async change:
Like mcbans did back in the time, the proxy also did the checks on the main thread which had some big issues on our end when mcbans is slow or down.

About the last one (snapshot build):
@md_5 did some changes to the BungeeCord implementation changing some classes to interfaces, which needs a recompile for the binaries.

@ghost ghost assigned syamn Apr 26, 2013
@syamn
Copy link
Member

syamn commented Apr 26, 2013

Ok, looks pretty good changes :)
I'll test this code but sorry maybe it'll take a couple days.
And also we'll discuss whether to convert to maven project by considering the our devs environment.
Thanks!

@DerFlash
Copy link
Contributor Author

Sounds great. Take your time for sure.

The maven commit is just in addition. You may still work with the current environment while providing the pom.xml for user who want to add the project to eclipse in a second.
For sure one may update the pom dependencies from time to time, but thats just a small thing for some PR then again ;-)

<dependency>
<groupId>net.md-5</groupId>
<artifactId>bungeecord-proxy</artifactId>
<version>1.5-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct version?
https://oss.sonatype.org/content/groups/public/net/md-5/bungeecord-proxy/
I couldn't find this in their repository :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. Seems like I've mixed this with my local repo. Furthermore they've did some more changes lately so you only need the API dependency. I'll check if we can now use that one finally at version 1.5-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants