feat(registry): add Registry tab with server-side OAuth credential protection#1553
Draft
feat(registry): add Registry tab with server-side OAuth credential protection#1553
Conversation
Add a curated Registry tab in the sidebar for connecting to first-party MCP servers (Asana, GitHub, Notion, Linear, Jira) with one click. Client changes: - New RegistryTab component with server cards, connect/disconnect UI - Registry sidebar entry in mcp-sidebar.tsx - registryManaged flag skips workspace sync for registry servers - registrySlug threaded through OAuth flow for server-side secret injection - OAuth fetch interceptor sends registrySlug to proxy endpoint - localStorage persistence for registrySlug survives OAuth redirects Server changes: - OAuth proxy injects clientSecret server-side during token exchange - fetchRegistryCredentials helper fetches from Convex backend - isTokenExchangeUrl utility detects /token and /access_token endpoints Type changes: - ServerFormData: added registryManaged, registrySlug - ServerWithName: added registryManaged, registrySlug - MCPOAuthOptions: added registrySlug Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_secretis fetched from Convex and injected during token exchange in the Hono proxy — secrets never reach the browserregistryManagedflag keeps registry servers out of the Servers tab and skips workspace syncregistrySlugis threaded through the OAuth flow (stored in localStorage to survive full-page redirects)Changes
Client
onConnect,onDisconnect, andserverspropsregistryto allowed hosted tabsregistrySlugthroughinitiateOAuth,handleOAuthCallback,refreshOAuthTokens, andclearOAuthData; parameterized fetch interceptor to include slug in proxy requestsregistryManagedandregistrySlugtoServerWithNameregistryManagedandregistrySlugtoServerFormDataServer
registrySlug, injectsclient_secretfor registry servers during token exchangeisTokenExchangeUrl()andfetchRegistryCredentials()helpersHooks
UPDATE_WORKSPACEdispatch for registry-managed servers; typedoauthOptionsasMCPOAuthOptionsCompanion PR
Backend changes (schema, seed, credentials endpoint, icon storage) in
mcpjam-backendrepo.Test plan
client_secretserver-side)🤖 Generated with Claude Code