Skip to content

Fix hosted callback 500 from missing join import#1590

Merged
chelojimenez merged 1 commit intomainfrom
codex/fix-hosted-callback-join
Mar 12, 2026
Merged

Fix hosted callback 500 from missing join import#1590
chelojimenez merged 1 commit intomainfrom
codex/fix-hosted-callback-join

Conversation

@chelojimenez
Copy link
Contributor

@chelojimenez chelojimenez commented Mar 12, 2026

Summary

  • import join from path in mcpjam-inspector/server/index.ts
  • fix hosted SPA fallback for deep links like /callback

Root cause

Production sign-in on app.mcpjam.com redirects to /callback, which goes through the SPA fallback in server/index.ts. That code calls join(...) to load dist/client/index.html, but join was never imported, so the fallback throws at runtime.

Railway logs for the production service show:
Error serving index.html: ReferenceError: join is not defined

Repro

  • https://app.mcpjam.com/ returns 200
  • https://app.mcpjam.com/callback?code=test returns 500 before this fix
  • arbitrary deep links like /foo also return 500 for the same reason

Testing

  • verified the production error via Railway logs
  • verified the code path uses join(...) without importing it before this change
  • did not run a full local build/test pass in this worktree because dependencies are not bootstrapped cleanly here

Note

Low Risk
Low risk: adds a missing join import to fix a runtime ReferenceError in the production SPA fallback path with no behavior changes beyond preventing 500s on deep links.

Overview
Fixes hosted production deep links (e.g. /callback) returning 500 by importing join from path in mcpjam-inspector/server/index.ts, preventing the SPA fallback index.html loader from throwing ReferenceError: join is not defined.

Written by Cursor Bugbot for commit b311afa. This will update automatically on new commits. Configure here.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 12, 2026
@chelojimenez
Copy link
Contributor Author

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@dosubot dosubot bot added the bug Something isn't working label Mar 12, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1683d3e-23c5-4235-842c-3ce9c4f69a75

📥 Commits

Reviewing files that changed from the base of the PR and between bd5c8b9 and b311afa.

📒 Files selected for processing (1)
  • mcpjam-inspector/server/index.ts

Walkthrough

The path module import in the server index file has been updated to include the join function. This modification adds join to the existing import statement from "path", resulting in a single line addition and removal. The change does not introduce any new functional behavior, as the imported function remains unused in the visible codebase.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chelojimenez chelojimenez merged commit 7ac2409 into main Mar 12, 2026
6 of 8 checks passed
@chelojimenez chelojimenez deleted the codex/fix-hosted-callback-join branch March 12, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant