Scope Logger suppression to armctl package and dependencies only#55
Closed
Scope Logger suppression to armctl package and dependencies only#55
Conversation
- use ctype u32 for robot status bit typing - add lamda function to make return dict clearer from function doctring
Co-authored-by: MGross21 <18691704+MGross21@users.noreply.github.com>
…nability Co-authored-by: MGross21 <18691704+MGross21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Link logger suppression to dependencies with loggers
Link Logger suppression to RTDE dependency logger
Feb 16, 2026
Owner
|
@copilot |
… global logging Co-authored-by: MGross21 <18691704+MGross21@users.noreply.github.com>
Co-authored-by: MGross21 <18691704+MGross21@users.noreply.github.com>
Contributor
Author
Changed to only suppress armctl and dependency loggers instead of using global |
Copilot
AI
changed the title
Link Logger suppression to RTDE dependency logger
Scope Logger suppression to armctl package and dependencies only
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RTDE library maintains its own logger instance that ignores
Logger.disable()andARMCTL_LOG=0, causing unwanted log output during controller version detection. Additionally, the original implementation usinglogging.disable(logging.CRITICAL)was suppressing ALL loggers globally in the Python process, which could affect other libraries.Changes
_LOGGERS_TO_MANAGElist containing "armctl" and "rtde" logger namespacesLogger.disable()to set logger levels toCRITICAL + 1(fully suppresses all messages) for armctl and dependency loggers onlyLogger.enable()to reset logger levels toNOTSETfor armctl and dependency loggerslogging.disable()calls - no longer affects other libraries' loggersLogger.disable()Behavior
Logger.disable()andARMCTL_LOG=0now only suppress:Other library loggers continue to work normally and are NOT affected.
Example
The
_LOGGERS_TO_MANAGElist makes it straightforward to add additional dependency loggers as needed.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.