migrate to rye #16
migrate to rye #16
Conversation
WalkthroughThe high-level summary of the changes involves transitioning the Python project's dependency management and code quality assurance methods. Specifically, it includes switching from Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 2 2
Lines 506 506
=======================================
Hits 499 499
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
poetry.lockis excluded by:!**/*.lockpyproject.tomlis excluded by:!**/*.tomlrequirements-dev.lockis excluded by:!**/*.lockrequirements.lockis excluded by:!**/*.lock
Files selected for processing (3)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
- src/earcut_py/init.py (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/test.yml
- src/earcut_py/init.py
Additional comments: 2
.github/workflows/lint.yml (2)
- 18-18: The
cacheoption is correctly set to"pip"to enable caching of dependencies installed with pip. This aligns with the migration from Poetry to pip and should improve the efficiency of the workflow runs by reusing the cached dependencies.- 23-26: Installing dependencies using pip directly from lock files (
requirements-dev.lockandrequirements.lock) is a good practice for ensuring consistency across environments. However, ensure that these lock files are generated and maintained accurately to reflect the project's dependencies.
| - name: Install Ruff | ||
| run: pip3 install ruff |
There was a problem hiding this comment.
The installation of Ruff is still present in the workflow. Given the PR's objective to migrate linting and formatting to Rye, this step appears to be outdated and should be removed or replaced with the installation of Rye.
- - name: Install Ruff
- run: pip3 install ruffCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - name: Install Ruff | |
| run: pip3 install ruff |
.github/workflows/lint.yml
Outdated
| - name: Lint | ||
| run: ruff lint --output-format=github |
There was a problem hiding this comment.
The lint command has been updated to use ruff lint --output-format=github. However, the tool mentioned should be rye instead of ruff, according to the PR objectives. This needs to be corrected to align with the migration to Rye for linting.
- run: ruff lint --output-format=github
+ run: rye lint --output-format=githubCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - name: Lint | |
| run: ruff lint --output-format=github | |
| - name: Lint | |
| run: rye lint --output-format=github |
| - name: Format | ||
| run: ruff format --check |
There was a problem hiding this comment.
Similar to the lint command, the format command is still using ruff format --check. This should be updated to use rye to align with the PR's objective of migrating to Rye for formatting.
- run: ruff format --check
+ run: rye format --checkCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| - name: Format | |
| run: ruff format --check | |
| - name: Format | |
| run: rye format --check |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
poetry.lockis excluded by:!**/*.lockpyproject.tomlis excluded by:!**/*.tomlrequirements-dev.lockis excluded by:!**/*.lockrequirements.lockis excluded by:!**/*.lock
Files selected for processing (3)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
- src/earcut_py/init.py (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/lint.yml
- .github/workflows/test.yml
- src/earcut_py/init.py
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
poetry.lockis excluded by:!**/*.lockpyproject.tomlis excluded by:!**/*.tomlrequirements-dev.lockis excluded by:!**/*.lockrequirements.lockis excluded by:!**/*.lock
Files selected for processing (3)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
- src/earcut_py/init.py (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/lint.yml
- .github/workflows/test.yml
- src/earcut_py/init.py
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
poetry.lockis excluded by:!**/*.lockpyproject.tomlis excluded by:!**/*.tomlrequirements-dev.lockis excluded by:!**/*.lockrequirements.lockis excluded by:!**/*.lock
Files selected for processing (3)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/test.yml (1 hunks)
- tests/test_fixtures.py (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/lint.yml
- .github/workflows/test.yml
Summary by CodeRabbit
earcut-pyモジュールにhello()関数を追加しました。ruffからryeに切り替えました。