-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow: release to PyPI #17
Conversation
WalkthroughA new GitHub Actions workflow named "Release" is introduced to automate the project's build using Rye on Ubuntu and publish package distributions to PyPI when triggered by releases. Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 2 2
Lines 506 506
=======================================
Hits 499 499
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/release.yml (1 hunks)
Additional comments: 4
.github/workflows/release.yml (4)
- 3-6: The workflow is currently triggered by pull requests, which might lead to unintended releases on every pull request merge. Consider using a tag-based trigger or manual dispatch for releases to ensure more control over when releases occur.
- 17-18: Installing Rye using
curl | bash
poses a security risk if the URL is compromised. Consider downloading the script first, verifying its integrity with a checksum, and then executing it.- 20-21: The build step using Rye appears appropriate and straightforward for the project's needs.
- 23-24: Ensure that PyPI API tokens are securely stored as GitHub Secrets and that the workflow permissions are correctly configured to access these secrets for publishing.
8ad7c00
to
abb1984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/release.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
abb1984
to
14f8164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/release.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
14f8164
to
257ce28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/release.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
257ce28
to
bdb8a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
pyproject.toml
is excluded by:!**/*.toml
Files selected for processing (1)
- .github/workflows/release.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
Summary by CodeRabbit