-
-
Notifications
You must be signed in to change notification settings - Fork 20
Add /ping route and request logging middleware for backend #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /ping route and request logging middleware for backend #62
Conversation
|
@Srishti-Aggarwal14 is attempting to deploy a commit to the mihir2006's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for creating this PRWe'll review it as soon as possible. If there are any unresolved review comments, feel free to resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Srishti-Aggarwal14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces foundational improvements to the backend's operational visibility and health monitoring. It adds a basic /ping endpoint for quick service status checks and integrates a request logging middleware to provide real-time insights into API traffic and response outcomes. Additionally, there are updates to the project's dependency lock file, reflecting changes in development dependency classification.
Highlights
- New /ping Route: A new
/pingendpoint has been added to the backend, returning{"message": "pong"}. This route serves as a simple health check to verify the service's availability. - Request Logging Middleware: An HTTP middleware,
log_requests, has been implemented to log details of incoming requests and their corresponding response statuses. This enhances observability by printing the request method, URL, and response status code to the console for every HTTP interaction. - Dependency Management Update: The
package-lock.jsonfile has been updated, primarily by adjusting thedevstatus of numerous dependencies. Many entries had"dev": trueremoved or changed to"devOptional": true, indicating a refinement in how development dependencies are tracked or managed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a /ping health check endpoint and a request logging middleware. While these additions are functional, the PR also removes the inclusion of all API routers and database initialization from main.py. This is a critical breaking change that disables the application's core functionality and is not mentioned in the PR description. I have raised a critical issue about this. Additionally, the new logging middleware uses print() statements, which is not ideal for a production environment. I've provided a suggestion to use Python's standard logging module for more robust logging.
Code Review
Closing this PR due to the critical breaking change. |
Added a /ping route for health checking
Added middleware to log incoming requests