Skip to content

Fix bug in {Char,String}.fromCString #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthewFluet merged 1 commit into from
Sep 18, 2026
Merged

Fix bug in {Char,String}.fromCString #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
= CHANGELOG

* 2026-09-18
** Fix bug in `Char.fromCString` and `String.fromCString` that
erroneously accepted an unescaped double quote character.
Thanks to https://github.com/Skyb0rg007/sml-basis-tests for
the (implicit) bug report.

* 2026-09-17
** Fix bug in handling of overload resolution with respect to
equality types. Thanks to Byron Zhong (zbyrg) for the bug report
Expand Down
6 changes: 4 additions & 2 deletions basis-library/text/char.sml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
(* Copyright (C) 1999-2007 Henry Cejtin, Matthew Fluet, Suresh
(* Copyright (C) 2026 Matthew Fluet.
* Copyright (C) 1999-2007 Henry Cejtin, Matthew Fluet, Suresh
* Jagannathan, and Stephen Weeks.
* Copyright (C) 1997-2000 NEC Research Institute.
*
Expand Down Expand Up @@ -271,7 +272,8 @@ functor CharFn(Arg : CHAR_ARG)
if Char.>= (c, #" ") andalso Char.<= (c, #"~")
then
case c of
#"\\" => escape state
#"\"" => NONE
| #"\\" => escape state
| _ => SOME (fromChar c, state)
else NONE
in
Expand Down