Fixed CastSpellByName not being able to self cast#12
Open
DBFBlackbull wants to merge 1 commit intoMOUZU:masterfrom
Open
Fixed CastSpellByName not being able to self cast#12DBFBlackbull wants to merge 1 commit intoMOUZU:masterfrom
DBFBlackbull wants to merge 1 commit intoMOUZU:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CastSpellByName has a self cast option described here: https://wowwiki-archive.fandom.com/wiki/API_CastSpellByName
The argument for the self cast was missing, meaning that just by having this addon active on your character all macros of the type
CastSpellByName("spell_name",1)would fail to self cast, and only work as a regular cast.By adding in the missing argument self casting is now restored.
I also indented line 562 to match the formatting of the surrounding code.