Remove 'pointer' attribute from 'inlist' argument to mpas_dmpar_scatter_ints #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
pointer
attribute from theinlist
dummy argument of thempas_dmpar_scatter_ints
routine.The
pointer
attribute is unnecessary for theinlist
argument, and requiring theinlist
argument to be a pointer precluded the use ofmpas_dmpar_scatter_ints
for arrays that are not pointers, e.g., allocatable arrays or array constructors. Additionally, since theinlist
argument is used only as the first argument toMPI_Scatterv
(i.e., as thesendbuf
argument ofMPI_Scatterv
), it can be declared as anintent(in)
in thempas_dmpar_scatter_ints
routine.The changes in this PR have also been found to resolve runtime errors occurring with certain compiler and MPI library combinations, specifically, nvfortran and OpenMPI 5.x.