Skip to content

Move boolean values to strings.#14

Open
moritzbuhl wants to merge 1 commit intoMPK1:mainfrom
moritzbuhl:patch-1
Open

Move boolean values to strings.#14
moritzbuhl wants to merge 1 commit intoMPK1:mainfrom
moritzbuhl:patch-1

Conversation

@moritzbuhl
Copy link
Copy Markdown
Contributor

On web the boolean values are not displayed (in my browser) and especially cause confusion for the H3 entry of linuxquic.

On web the boolean values are not displayed (in my browser) and especially cause confusion for the H3 entry of linuxquic.
@MPK1
Copy link
Copy Markdown
Owner

MPK1 commented Apr 6, 2025

This might be caused by the fact that they are "pretty printed" with emojis (e.g, Unicode 0x2705), see here. Your proposal should immediately fix this, but using a string variable to store a boolean is kind of suboptimal. I would rather suggest changing the way of "pretty printing" so that all browsers support it or at least add some fallback that prints "true/false". If you tell me which browser you're using, I can quickly try some ideas to fix this.

@moritzbuhl
Copy link
Copy Markdown
Contributor Author

This is how it looks like in my Firefox (on OpenBSD):
Screenshot 2025-04-08 at 10-52-04 QUIC Explorer linuxquic
Looks like my Firefox has some problems displaying emojis. I cannot even see them in the source code viewer on GitHub:
image

But since the link mdi icon works, maybe it would make sense to replace the checkmark and cross emojis in the js with spans?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants