Resolved issues with Surface devices #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where a systemsku with : in it would break driver detection for that sku Fixed issue where space in the SystemSKU would cause $DriverPackageInputArray in Confirm-SystemSKU to have an empty array Fixed issue where falling back to Confirm-ComputerModel would cause the script to error out from to many matches. Disabled the Fallback
This reverts commit d317d9c.
…ction for that sku Fixed issue where space in the SystemSKU would cause $DriverPackageInputArray in Confirm-SystemSKU to have an empty array Fixed issue where falling back to Confirm-ComputerModel would cause the script to error out from to many matches. Disabled the Fallback
|
More information on Fixed issue where space in the SystemSKU would cause $DriverPackageInputArray in Confirm-SystemSKU to have an empty array. $DriverPackageInputArray = $DriverPackageInput.Replace(" ", ",").Split($SystemSKUDelimiter) | Select-Object -Unique was changed in an earlier commit to resolve an issue with spaces in the SystemSKU, but this fix also causes an empty array item to be added to $DriverPackageInputArray like so: if ($ComputerData.SystemSKU -match $SystemSKUItem) will match as true on an empty array and add in a driver that shouldn't have been added in which will end up causing the error:
Run the script without the above fix using the below command line: Below from log:
|
|
Guessing this is related to what I'm seeing in #31, where drivers for Surface devices are being download from Dell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have resolved the issues with 4.0.2 and surface devices. I did have to disable fallback model detection to get it to work correctly.